Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BRE - EE demo #5164

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

BRE - EE demo #5164

wants to merge 5 commits into from

Conversation

mimartin12
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.15%. Comparing base (b75c63c) to head (ba51dcf).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5164   +/-   ##
=======================================
  Coverage   43.15%   43.15%           
=======================================
  Files        1452     1452           
  Lines       66287    66301   +14     
  Branches     6072     6073    +1     
=======================================
+ Hits        28606    28615    +9     
- Misses      36394    36398    +4     
- Partials     1287     1288    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-devops-bot
Copy link
Contributor

Ephemeral Environment Details:
Web: https://bre-demo-ee-01.ee.bitwarden.pw/
Api: https://bre-demo-ee-01.ee.bitwarden.pw/api

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 02569bf5-6e92-4b8a-a8bc-59473f4cfe3f

No New Or Fixed Issues Found

@bitwarden-devops-bot
Copy link
Contributor

Ephemeral Environment Details:
Web: https://bre-demo-ee-01.ee.bitwarden.pw/
Api: https://bre-demo-ee-01.ee.bitwarden.pw/api

@bitwarden-devops-bot
Copy link
Contributor

Ephemeral Environment Details:
Web: https://bre-demo-ee-01.ee.bitwarden.pw/
Api: https://bre-demo-ee-01.ee.bitwarden.pw/api

@bitwarden-devops-bot
Copy link
Contributor

Ephemeral Environment Details:
Web: https://bre-demo-ee-01.ee.bitwarden.pw/
Api: https://bre-demo-ee-01.ee.bitwarden.pw/api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ephemeral-environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimartin12 @bitwarden-devops-bot